Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Dense account design #3428

Merged
merged 11 commits into from
Aug 26, 2024
Merged

[FEATURE] Dense account design #3428

merged 11 commits into from
Aug 26, 2024

Conversation

shamim-emon
Copy link
Member

@shamim-emon shamim-emon commented Aug 25, 2024 •
edited
Loading

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

What's changed?

Describe with a few bullets what's new:

  • I've updated account design of Accounts tab.

Risk factors

What may go wrong if we merge your PR?

  • No known issue.

In what cases won't your code work?

  • No known case

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

@shamim-emon shamim-emon changed the title Dense account design [FEATURE] Dense account design Aug 25, 2024
@shamim-emon shamim-emon marked this pull request as draft August 25, 2024 10:36
@shamim-emon shamim-emon marked this pull request as ready for review August 25, 2024 10:51
ILIYANGERMANOV
ILIYANGERMANOV requested changes Aug 25, 2024
View reviewed changes
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must not change the default design. Instead create a new one and show if a "Compact accounts" feature flag from IvyFeatures is enabled

@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Aug 25, 2024
ILIYANGERMANOV
ILIYANGERMANOV requested changes Aug 25, 2024
View reviewed changes
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Starts to look good 💯 Left some comments

shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt Outdated Show resolved Hide resolved
shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt Outdated Show resolved Hide resolved
shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt Outdated Show resolved Hide resolved
screen/accounts/src/test/java/com/ivy/accounts/AccountsTabPaparazziTest.kt Show resolved Hide resolved
screen/accounts/src/main/java/com/ivy/accounts/AccountsViewModel.kt Outdated Show resolved Hide resolved
screen/accounts/src/main/java/com/ivy/accounts/AccountsViewModel.kt Outdated Show resolved Hide resolved
screen/accounts/src/main/java/com/ivy/accounts/AccountsViewModel.kt Outdated Show resolved Hide resolved
screen/accounts/src/main/java/com/ivy/accounts/AccountsTab.kt Outdated Show resolved Hide resolved
screen/accounts/src/main/java/com/ivy/accounts/AccountsState.kt Outdated Show resolved Hide resolved
shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt Outdated Show resolved Hide resolved
ILIYANGERMANOV
ILIYANGERMANOV approved these changes Aug 25, 2024
View reviewed changes
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the CI and we can merge

@ILIYANGERMANOV ILIYANGERMANOV added ready to merge 🚀 PR can be merged after the CI pass and removed requested changes Changes are needed. Please, apply them labels Aug 25, 2024
@shamim-emon
Copy link
Member Author

Fix the CI and we can merge

Ok will fix it soon!

@ILIYANGERMANOV ILIYANGERMANOV merged commit a116fff into Ivy-Apps:main Aug 26, 2024
9 checks passed
@shamim-emon shamim-emon deleted the fix-issue-3297 branch August 26, 2024 09:04
@Jack-Works
Copy link
Contributor

wow, I tried it, it works well, thanks!

@shamim-emon
Copy link
Member Author

wow, I tried it, it works well, thanks!

Welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ILIYANGERMANOV ILIYANGERMANOV ILIYANGERMANOV approved these changes

Assignees
No one assigned
Labels
ready to merge 🚀 PR can be merged after the CI pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Dense account design
3 participants
@shamim-emon @Jack-Works @ILIYANGERMANOV